wire-server chart: Disable integration chart by default#3682
Merged
wire-server chart: Disable integration chart by default#3682
Conversation
zebot
added
the
ok-to-test
smatting
force-pushed
the
integration-disable-by-default
branch
from
e472840 to
1d5ce2f
Compare
supersven
approved these changes
Apr 8, 2024
Contributor
supersven
left a comment
supersven
left a comment
There was a problem hiding this comment.
LGTM 👍
(Let's wait for the CI before merging.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixup to #3171. This PR updates the
wire-serverchart so that it doesn't include theintegrationchart by default.Without this PR the integration chart is installed, which creates an superfluous kubernetes objects, including an (internal) ingress for a subdomain of
svc.cluster.local.Disabling works because of this tag
Checklist
changelog.d